svemagie.net/indiekit-endpoint-activitypub
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(federation): wire baseUrl through createFedifyMiddleware to fromExpressRequest

Browse Source 
The function was called with publicationUrl as 3rd arg (ap-base-url patch)
but never accepted it — Fedify saw localhost:3000 instead of blog.giersig.eu,
causing webfinger hostname check to fail and return onNotFound → next() →
indieauth.authenticate() → 302 redirect for all public federation endpoints.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
svemagie
2026-04-25 21:16:07 +02:00
parent ba4bb53f0d
commit f03f9050d9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/federation-bridge.js
+2 -2
View File
@@ -143,7 +143,7 @@ async function sendFedifyResponse(res, response, request) {
* @param {Function} contextDataFactory - (req) => contextData * @param {Function} contextDataFactory - (req) => contextData
* @returns {import("express").RequestHandler} * @returns {import("express").RequestHandler}
*/ */
export function createFedifyMiddleware(federation, contextDataFactory) { export function createFedifyMiddleware(federation, contextDataFactory, baseUrl) { // ap-base-url patch
return async (req, res, next) => { return async (req, res, next) => {
try { try {
// Buffer application/activity+json and ld+json request bodies ourselves — // Buffer application/activity+json and ld+json request bodies ourselves —
@@ -180,7 +180,7 @@ export function createFedifyMiddleware(federation, contextDataFactory) {
return res.status(200).end(); return res.status(200).end();
} }
const request = fromExpressRequest(req); const request = fromExpressRequest(req, baseUrl); // ap-base-url patch
const contextData = await Promise.resolve(contextDataFactory(req)); const contextData = await Promise.resolve(contextDataFactory(req));
let notFound = false; let notFound = false;