svemagie.net/blog-eleventy-indiekit
1
0
Fork 0
mirror of https://github.com/svemagie/blog-eleventy-indiekit.git synced 2026-05-14 22:48:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: use page.url instead of permalink for ogSlug in templates

Browse Source 
permalink is set by eleventyComputed which cross-contaminates return
values across pages during Eleventy 3.x parallel rendering. page.url
is set by Eleventy's internal pipeline and is correct in templates
(verified via og:url meta tag which always shows the right URL).
This commit is contained in:
Ricardo
2026-02-24 18:54:39 +01:00
parent 7110ba3879
commit ad8af6f027
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
_includes/layouts/base.njk
+6 -4
View File
@@ -23,10 +23,12 @@
<meta property="og:type" content="{% if page.url == '/' %}website{% else %}article{% endif %}"> <meta property="og:type" content="{% if page.url == '/' %}website{% else %}article{% endif %}">
<meta property="og:description" content="{{ ogDesc }}"> <meta property="og:description" content="{{ ogDesc }}">
<meta name="description" content="{{ ogDesc }}"> <meta name="description" content="{{ ogDesc }}">
{# Compute OG slug from permalink (frontmatter), NOT page.url or eleventyComputed. {# Compute OG slug from page.url — NOT permalink or eleventyComputed values.
permalink is per-file data immune to Eleventy 3.x parallel rendering race conditions. Eleventy 3.x parallel rendering (issue #3183) cross-contaminates eleventyComputed
page.url, page.inputPath, and eleventyComputed values can return data from OTHER pages. #} return values across pages. permalink is set by eleventyComputed and is UNRELIABLE.
{% set _ogSlug = permalink | ogSlug %} page.url is set by Eleventy's internal pipeline and IS correct in templates
(verified: og:url uses page.url and always shows the right URL). #}
{% set _ogSlug = page.url | ogSlug %}
{% set _hasOg = _ogSlug | hasOgImage %} {% set _hasOg = _ogSlug | hasOgImage %}
{% if ogPhoto and ogPhoto != "" and (ogPhoto | length) > 10 %} {% if ogPhoto and ogPhoto != "" and (ogPhoto | length) > 10 %}
<meta property="og:image" content="{% if 'http' in ogPhoto %}{{ ogPhoto }}{% else %}{{ site.url }}{% if ogPhoto[0] != '/' %}/{% endif %}{{ ogPhoto }}{% endif %}"> <meta property="og:image" content="{% if 'http' in ogPhoto %}{{ ogPhoto }}{% else %}{{ site.url }}{% if ogPhoto[0] != '/' %}/{% endif %}{{ ogPhoto }}{% endif %}">